Skip to content

TCK: Provide test classes working directly on JDK9 interfaces #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ktoso opened this issue Jul 13, 2017 · 7 comments · Fixed by #398
Closed

TCK: Provide test classes working directly on JDK9 interfaces #388

ktoso opened this issue Jul 13, 2017 · 7 comments · Fixed by #398

Comments

@ktoso
Copy link
Contributor

ktoso commented Jul 13, 2017

There's two ways to go about this I guess:

Proposed style of rolling it out:

  • change TCK code to work on JDK9 interfaces directly
  • make current Verification classes go through adapters provided via Create RS <-> JDK9 bridge jar #294
  • add new Verification classes (named like "FlowPublisher...Verification" etc, which new users can use then

This would move "us" to test the JDK things directly, which is the end goal and allow slowly moving away from having to use the adapters for most impls (as impls move to implementing the JDK interfaces)

@viktorklang
Copy link
Contributor

@ktoso I believe you wanted to take a stab at this? :)

@ktoso
Copy link
Contributor Author

ktoso commented Oct 2, 2017

Yes, absolutely - work in progress already.
Terribly jet-lagged though, hope a good nights sleep today will get me hacking on to finish this up on monday US time.

@viktorklang
Copy link
Contributor

viktorklang commented Oct 2, 2017 via email

@akarnokd
Copy link
Contributor

akarnokd commented Oct 2, 2017

This should be simply a copy-paste of the current TCK in a new module and replacing org.reactivestreams with java.util.concurrent.Flow, right?

@ktoso
Copy link
Contributor Author

ktoso commented Oct 2, 2017 via email

@akarnokd
Copy link
Contributor

akarnokd commented Oct 2, 2017

I'm not a Gradle guru but I'm sure it can be automatically synchronized via scripting.

@akarnokd
Copy link
Contributor

akarnokd commented Oct 2, 2017

I'm not a Gradle guru but I'm sure it can be automatically synchronized via scripting.

Nope, it's still tedious as the references have to be carefully replaced since the containing package is org.reactivestreams too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants