Release 1.0.1 #345

viktorklang · 2017-03-13T09:15:16Z

I propose that we, @reactive-streams/contributors, release 1.0.1 on the 2-year anniversary of 1.0.0

No semantically breaking changes.

Improved TCK? Improved docs? Improved spec?

akarnokd · 2017-03-14T18:05:18Z

How urgent is this? I might have found an issue with PublisherVerification: some tests don't cancel the test Subscriber's Subscription which leaves the created Publisher hanging or leaking resources.

My suspects are the spec111_multicast_* because in my TestNG execution, the test required_createPublisher1MustProduceAStreamOfExactly1Element failed when the whole suite was executed but passed when the individual test was executed.

I'm currently preparing a TCK test that should detect if cancel was called in a particular test if there was no onComplete from the created Publisher.

viktorklang · 2017-03-14T18:16:31Z

The 2-year anniversary is on the 29th of April :)

smaldini · 2017-03-20T11:57:08Z

I'll be ready to publish it but i think it's a good idea. Could we reference in this ticket issues we are going to address (or label them) ? In particular would this come with the soft breaking about request(0) not erroring ?

viktorklang · 2017-03-24T19:17:19Z

@smaldini I'd love to discuss that "problem" (request(0)) but not on this Issue :)

I believe all tickets are assigned to the milestone.

(And thanks for volunteering to release!!)

DougLea · 2017-03-24T19:30:45Z

Just FYI, jdk was successfully changed to reject request(0) for initial jdk9 release, even though I still think it was a bad idea. But better to conform to 1.0 spec anyway...

viktorklang · 2017-03-24T20:19:31Z

Thanks @DougLea!

viktorklang · 2017-07-03T09:56:37Z

@reactive-streams/contributors Has everyone updated their implementations to try the new TCK?
Are we good to go on promoting the RC1 to final? Please report back here ASAP.

ktoso · 2017-07-03T10:00:23Z

Akka Streams passing: akka/akka#23267 👍

(Let's await some more impls to upgrade, at least 3 or 4 I'd say)

akarnokd · 2017-07-03T10:12:09Z

RxJava 2.1.2 snapshot passing: ReactiveX/RxJava#5453

Please give the 1.0.1 Release Candidate 1 TCK a run so we can be sure it did not cause any unexpected regressions / changes. See here for libraries updating to 1.0.1 process: reactive-streams/reactive-streams-jvm#345 Thanks in advance!

ktoso · 2017-07-03T16:04:13Z

I made a PR in Vert.X asking to check the RC: vert-x3/vertx-reactive-streams#9

smaldini · 2017-07-03T16:20:50Z

I'll check in a moment today thanks @reactive-streams/contributors

viktorklang · 2017-07-04T14:35:27Z

@smaldini Any verdict?

@DougLea Doug, have you had any chance to run the newer TCK on your SubPub?

ktoso · 2017-07-04T15:09:59Z

FYI VertX did not reply on my ticket so far.

smaldini · 2017-07-04T15:32:59Z

Give us one more day its one of those very few bank holiday in the US :)

akarnokd · 2017-07-04T15:53:10Z

JDK 9b176 via this:

37 tests done, 2 failed, 15 ignored

SubmissionPublisherTckTest.required_spec309_requestNegativeNumberMustSignalIllegalArgumentException

java.lang.AssertionError: Got expected exception [class java.lang.IllegalArgumentException] but missing message part [3.9], was: non-positive subscription request

SubmissionPublisherTckTest.required_spec309_requestZeroMustSignalIllegalArgumentException

java.lang.AssertionError: Got expected exception [class java.lang.IllegalArgumentException] but missing message part [3.9], was: non-positive subscription request

DougLea · 2017-07-04T16:01:18Z

On 07/04/2017 11:53 AM, David Karnok wrote: JDK 9b176 via this <https://github.com/akarnokd/akarnokd-misc-java9/blob/master/src/hu/akarnokd/java9/benchmark/SubmissionPublisherTckTest.java>:

Thanks. I was in the midst of trying to reconstruct this.

37 tests done, 2 failed, 15 ignored

As discussed originally, We must use the usual JDK exception message formats for all exceptions, not RS-spec rule quotes. All other rs-tck tests accommodate this, but I hadn't checked against the annoying non-positive argument check added months ago. Can the text-match be loosened?

…

-Doug

SubmissionPublisherTckTest.required_spec309_requestNegativeNumberMustSignalIllegalArgumentException java.lang.AssertionError: Got expected exception [class java.lang.IllegalArgumentException] but missing message part [3.9], was: non-positive subscription request SubmissionPublisherTckTest.required_spec309_requestZeroMustSignalIllegalArgumentException java.lang.AssertionError: Got expected exception [class java.lang.IllegalArgumentException] but missing message part [3.9], was: non-positive subscription request — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#345 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACIWPw7qBSogE7r5DC3BTqfBQNBuJ4uqks5sKl_ogaJpZM4MbALd>.

ktoso · 2017-07-04T16:15:58Z

Right, I guess we'll have to loosen up a bit - I'll handle that;
I think rule reference or "non-positive" string appearance should be fine

viktorklang · 2017-07-04T16:16:15Z

@DougLea The text-match could be loosened—it is there to make sure that the IAE doesn't stem from something else (the alternative would be to introduce a new Exception type, which would IMO not pull its weight).

viktorklang · 2017-07-04T16:16:26Z

@smaldini Ok :)

viktorklang · 2017-07-04T16:45:41Z

1:9 and 2:13 do not mandate that the rule is referenced in the cause message so I think it'd actually be more reasonable to drop the requirement. Thoughts? (It is of course completely backwards compatible)

ktoso · 2017-07-04T17:00:51Z

1:9 and 2:13 do not mandate that the rule is referenced in the cause message so I think it'd actually be more reasonable to drop the requirement. Thoughts? (It is of course completely backwards compatible)

Yeah, very good point. We even have to do so, otherwise the TCK would allow "not quite the spec abiding" impls to pass. Since the JDK's interfaces have their own style of messages, and will soon become the "main" interfaces, we should make sure they fit the rules (or rather, the rules in this case fit them).

Sanity checking: Yes, it's definitely backwards compatible - we require less from implementations now.

PRed separately from TCK change in case this requires more discussion, but seems pretty obvious: #386

ktoso · 2017-07-07T05:46:47Z

3 day after reminder;
Ping @smaldini, were you able to upgrade? It does not take much time and we want to ship an RC2 with: #386 #385
So please give it a try and give those a look - thanks!

smaldini · 2017-07-07T07:19:24Z

You should go ahead then with RC2 i'll batch update, sorry i'm in the middle of some widespread polishing that is loosely connected to RS (properly recognizing 1.3 and 3.9).

ktoso · 2017-07-12T09:01:28Z

It was only staged, not closed, so won't get to central yet.
With 2 projects having confirmed artifacts are fine I think we can close/release it I think - i can click the button ;)

viktorklang · 2017-07-12T09:02:46Z

@ktoso Yes please!

ktoso · 2017-07-12T09:03:45Z

Shipping Thanks Roland for preparing the artifacts and David for checking they're fine 👍

rkuhn · 2017-07-12T11:21:12Z

Sorry, guys, between your confirmations and the release to Maven I had some urgent business matters to attend to. Thanks @ktoso for helping out!

ktoso · 2017-07-12T14:16:05Z

No worries, let the businessing go well :-)

It's out: http://repo1.maven.org/maven2/org/reactivestreams/reactive-streams/1.0.1-RC2/

viktorklang · 2017-07-13T13:03:37Z

@smaldini Any update on RC2? :)

smaldini · 2017-07-13T14:37:35Z

Yup we;re good on our side, I removed some exceptions to the tck but I have 2 remaining one I need to investigate regarding two test expectations regarding a processor. Also I used the 3.1 to get back on track for spec we discussed (allowing onError on request), so we don't have this exception anymore like rxjava, good citizen again.
LGTM

smaldini · 2017-08-03T22:14:19Z

So when do you think we shall proceed to GA ?

ktoso · 2017-08-04T03:48:01Z

We're waiting for info if you're passing the TCK :-)

smaldini · 2017-08-04T05:32:17Z

Oh yes we do!

ktoso · 2017-08-04T06:33:53Z

Completely, right? Including the issues you mentioned above?
If so, then I think we're good to call the 1.0.1, at least IMHO :-)

viktorklang · 2017-08-04T07:02:03Z

If all TCK tests pass then I think we should ship 1.0.1 next week.

…

-- Cheers, √

On Aug 4, 2017 08:33, "ktoso" ***@***.***> wrote: Completely, right? Including the issues you mentioned above? If so, then I think we're good to call the 1.0.1, at least IMHO :-) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#345 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAqd6Gh3VOBVdYZUDHTsbkWOFi7wrr7ks5sUrtRgaJpZM4MbALd> .

smaldini · 2017-08-08T00:31:31Z

👍 We got back on track by adopting internal/external facing subscriber protocol so we respect the rules (especially the onError possible from request)

akarnokd · 2017-08-08T12:09:14Z

RxJava 2 ready for 1.0.1! 👍

viktorklang · 2017-08-09T09:14:30Z

@rkuhn would you be able to do us the honors of cutting the release within the next 8h? From the following tag I just pushed: https://github.com/reactive-streams/reactive-streams-jvm/tree/v1.0.1

Let me know if you won't have time today and I'll try to sort it out some other way, ok? 👍

I'll prepare the website, then upload javadoc etc.

rkuhn · 2017-08-09T09:16:29Z

Yes, I’ll do it around lunch time.

viktorklang · 2017-08-09T09:25:47Z

Vielen dank, dr. Kuhn!

…

-- Cheers, √

On Aug 9, 2017 11:16 AM, "Roland Kuhn" ***@***.***> wrote: Yes, I’ll do it around lunch time. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#345 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAqd8wAoqvLNSBDqApIMLZHInWR0ME4ks5sWXjugaJpZM4MbALd> .

rkuhn · 2017-08-09T10:27:01Z

The artifacts are staged at https://oss.sonatype.org/content/repositories/orgreactivestreams-1032, please let me know when to release them.

akarnokd · 2017-08-09T10:30:32Z

👍 for release asap.

viktorklang · 2017-08-09T10:41:27Z

Thanks @rkuhn, I'm currently working to make sure that website, documentation links etc are updated. Would you be OK with releasing them 4pm CEST? (That way I have an extra couple of hours to verify things over at my end)

rkuhn · 2017-08-09T11:33:43Z

Sure thing!

viktorklang · 2017-08-09T11:34:13Z

@rkuhn Perfect, thank you!

rkuhn · 2017-08-09T14:01:24Z

So, shall I press the button now?

viktorklang · 2017-08-09T14:08:52Z

Yes!

akarnokd · 2017-08-09T14:25:31Z

Will you or somebody post the 1.0.1 javadoc to

http://www.reactive-streams.org/reactive-streams-1.0.1-javadoc/

?

viktorklang · 2017-08-09T14:26:49Z

I have a PR I will merge for that once I see the artifacts replicated to Maven Central.

…

-- Cheers, √

On Aug 9, 2017 16:25, "David Karnok" ***@***.***> wrote: Will you or somebody post the 1.0.1 javadoc to http://www.reactive-streams.org/reactive-streams-1.0.1-javadoc/ ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#345 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAqdw3EzDL8kXElZ16fSyJ5ecDSKR0bks5sWcFcgaJpZM4MbALd> .

rkuhn · 2017-08-09T14:44:46Z

The artifacts are on Maven Central.

viktorklang · 2017-08-09T14:48:14Z

Excellent! reactive-streams.org has been updated, great work everyone!! 🎆🎆🎆🎆🎆🎂🎂😎

ktoso · 2017-08-09T15:09:16Z

Excellent! 🎆
Kudos and thanks everyone :)

viktorklang added the enhancement label Mar 13, 2017

viktorklang added this to the 1.0.1 milestone Mar 13, 2017

ktoso mentioned this issue Jul 3, 2017

Try reactive-streams 1.0.1-RC1 TCK vert-x3/vertx-reactive-streams#9

Closed

smaldini mentioned this issue Jul 3, 2017

Update to reactive-streams 1.0.1 reactor/reactor-core#711

Closed

ktoso mentioned this issue Jul 4, 2017

Loosen up 3.9 tests since JDK9 does not refer to RS rules directly #384

Closed

ktoso mentioned this issue Jul 4, 2017

=spec #384 amend spec to allow not mentioning rule number in exception message #386

Merged

viktorklang closed this as completed Aug 9, 2017

Release 1.0.1 #345

Release 1.0.1 #345

Comments

viktorklang commented Mar 13, 2017

akarnokd commented Mar 14, 2017

viktorklang commented Mar 14, 2017

smaldini commented Mar 20, 2017

viktorklang commented Mar 24, 2017 • edited Loading

DougLea commented Mar 24, 2017

viktorklang commented Mar 24, 2017

viktorklang commented Jul 3, 2017

ktoso commented Jul 3, 2017 • edited Loading

akarnokd commented Jul 3, 2017

ktoso commented Jul 3, 2017

smaldini commented Jul 3, 2017

viktorklang commented Jul 4, 2017

ktoso commented Jul 4, 2017

smaldini commented Jul 4, 2017

akarnokd commented Jul 4, 2017

DougLea commented Jul 4, 2017 via email

ktoso commented Jul 4, 2017 • edited Loading

viktorklang commented Jul 4, 2017

viktorklang commented Jul 4, 2017

viktorklang commented Jul 4, 2017

ktoso commented Jul 4, 2017

ktoso commented Jul 7, 2017 • edited Loading

smaldini commented Jul 7, 2017

ktoso commented Jul 12, 2017

viktorklang commented Jul 12, 2017

ktoso commented Jul 12, 2017

rkuhn commented Jul 12, 2017 via email

ktoso commented Jul 12, 2017

viktorklang commented Jul 13, 2017

smaldini commented Jul 13, 2017 • edited Loading

smaldini commented Aug 3, 2017

ktoso commented Aug 4, 2017 • edited Loading

smaldini commented Aug 4, 2017

ktoso commented Aug 4, 2017

viktorklang commented Aug 4, 2017 via email

smaldini commented Aug 8, 2017

akarnokd commented Aug 8, 2017

viktorklang commented Aug 9, 2017

rkuhn commented Aug 9, 2017

viktorklang commented Aug 9, 2017 via email

rkuhn commented Aug 9, 2017

akarnokd commented Aug 9, 2017

viktorklang commented Aug 9, 2017

rkuhn commented Aug 9, 2017 via email

viktorklang commented Aug 9, 2017

rkuhn commented Aug 9, 2017

viktorklang commented Aug 9, 2017

akarnokd commented Aug 9, 2017

viktorklang commented Aug 9, 2017 via email

rkuhn commented Aug 9, 2017

viktorklang commented Aug 9, 2017

ktoso commented Aug 9, 2017 • edited Loading

viktorklang commented Mar 24, 2017 •

edited

Loading

ktoso commented Jul 3, 2017 •

edited

Loading

ktoso commented Jul 4, 2017 •

edited

Loading

ktoso commented Jul 7, 2017 •

edited

Loading

smaldini commented Jul 13, 2017 •

edited

Loading

ktoso commented Aug 4, 2017 •

edited

Loading

ktoso commented Aug 9, 2017 •

edited

Loading