Skip to content

Remove non generic interfaces #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from Jun 9, 2016
Merged

Remove non generic interfaces #7

merged 4 commits into from Jun 9, 2016

Conversation

cconstantin
Copy link
Contributor

No description provided.

*.bim_*.settings

Copy link
Contributor

@viktorklang viktorklang May 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you mean here, it looks OK to me. No new line at the end of the line.

@cconstantin cconstantin mentioned this pull request May 31, 2016
@cconstantin
Copy link
Contributor Author

@viktorklang updated to publish 1.0.0-beta1. I'll remove existing packages and publish beta1 as soon as this is merged in.

@cconstantin cconstantin changed the title [WIP] Remove non generic interfaces Remove non generic interfaces May 31, 2016
@@ -0,0 +1,2 @@
#### 1.0.0 May 30 2016 ####
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this reflect another version number?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build script is tagging the package with "-beta1". Open to suggestions about what the version should be, but I think we can update it with a PR just before releasing. I'm not planning to release (and retract the old versions) until after the TCK is merged in.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this file should only list official, final releases. As such I think it is OK to keep it empty for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@viktorklang viktorklang merged commit 93a21c7 into reactive-streams:master Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants