Fix: Accidental mutation of old model causes invalid JSON Patch #802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
rmorshea
changed the title
rmorshea
force-pushed
the
json-patch-workaround
branch
2 times, most recently
from
6b2ab39 to
d1c6d37
Compare
rmorshea
force-pushed
the
json-patch-workaround
branch
10 times, most recently
from
1e146fa to
3eedca3
Compare
distutils has also been deprecated
rmorshea
force-pushed
the
json-patch-workaround
branch
from
3eedca3 to
ef593d6
Compare
Archmonger
reviewed
Aug 16, 2022
Comment on lines
+233
to
+243
| # need to add this model to parent's children without mutating parent model | ||
| old_parent_model = parent.model.current | ||
| old_parent_children = old_parent_model["children"] | ||
| parent.model.current = { | ||
| **old_parent_model, | ||
| "children": [ | ||
| *old_parent_children[:index], | ||
| new_state.model.current, | ||
| *old_parent_children[index + 1 :], | ||
| ], | ||
| } |
There was a problem hiding this comment.
Could this be the reason why VDOM children won't render if they follow a component?
There was a problem hiding this comment.
It might be related to the fact that I'm replacing the parent model on line 236? The fact that I'm not propagating this change up the model parents is probably a problem, but I can't quite see why that's causing your problem where the children are not rendering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #801
Checklist
Please update this checklist as you complete each item:
changelog.rsthas been updated with any significant changes.