Skip to content

fix mimetype issue #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2022
Merged

fix mimetype issue #762

merged 1 commit into from
Jun 16, 2022

Conversation

rmorshea
Copy link
Collaborator

@rmorshea rmorshea commented Jun 16, 2022

closes: #749. Needed to set mimetype for sanic server. The other implementations guess mimetypes based on file extensions (which appear to be getting set appropriately).

@github-actions
Copy link

Greet Contributors Bot
Hello @rmorshea! Please remember the following:

  • Update the changelog.rst if your changes are significant.
  • Provide a verbose PR title and description.
  • List any GitHub issues that may be closed by this PR.
  • Add tests if this PR adds functionality or bugfixes.
  • Keep this PR marked as draft until ready for review.

Thank you for your contribution!

The amazing contributor in this pull request is @rmorshea

@rmorshea rmorshea merged commit 009617d into main Jun 16, 2022
@rmorshea rmorshea deleted the fix-mimetypes branch June 16, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set web modules MIME Type
1 participant