Change function name in readme example #750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archmonger
added
the
flag-no-changelog
|
Side note, the new changelog check CI is fairly annoying. I think a "Welcome Message" CI reminding users to add a changelog entry if needed is a better approach. |
|
Yeah the changelog CI actions is definitely broken. Happy to just go with a welcome message on new MRs instead. |
|
This current PR is ready for review. A separate PR created to modify the CI: #752 |
rmorshea
approved these changes
May 6, 2022
|
Yep, greetings message is broken. |
|
It seems like this might be a more general problem with permissions around forked repos. |
rmorshea
approved these changes
May 31, 2022
|
I think I'll create my own "Greetings CI" repo to handle this without permissions. |
rmorshea
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just realized the name of the example in the readme is
App. However, we really want to focus on giving users a more realistic component name to get them on the right track.And truthfully, calling it
Appis a misnomer. The function itself is a component, even ifrun()is creating an ASGI app on the backend.