Update good_conditional_todo_list.py #745
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The checkmark was on the wrong list items compared to the more verbose example.
Update good_conditional_todo_list.py
|
Should the changes be listed in the unreleased changes section of |
|
If you could add that to the unreleased section of the changelog that would be great! |
|
actually nevermind. this isn't a functional change. I'll wave that check |
rmorshea
added
the
flag-no-changelog
fixed typo. It was rendering `1 or 10` instead of `1 of 10`
|
I have another typo fix that also doesnt change any functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This minor change updates the example in good_conditional_todo_list.py to match the expected behavior of the previous example where the completed items in the todo list had checkmarks.