Skip to content

Update running-idom.rst #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Update running-idom.rst #710

merged 1 commit into from
Mar 17, 2022

Conversation

jmtaysom
Copy link
Contributor

The run function does not have a config kwarg but instead server_config

The run function does not have a `config` kwarg but instead `server_config`
@rmorshea
Copy link
Collaborator

rmorshea commented Mar 17, 2022

Thanks @jmtaysom for the contribution!

A note on idom.run, we're thinking about making some changes to the run function since it encourages bad habits - namely that you should use a production WSGI or ASGI web server instead of the idom.run function. Given this, in the future, idom.run will become a tool for convenience while developing rather than something that should be used in production.

@jmtaysom
Copy link
Contributor Author

jmtaysom commented Mar 17, 2022 via email

@rmorshea
Copy link
Collaborator

I have also had issues with the shared runtime in the tutorial

Can you link to particular sections of the docs that you found to be problematic? I'll create an issue to track that.

@jmtaysom
Copy link
Contributor Author

jmtaysom commented Mar 17, 2022 via email

@rmorshea
Copy link
Collaborator

It looks like there may be two separate problems here. I'll open a discussion so we can tease them out.

@rmorshea rmorshea merged commit 3664706 into reactive-python:main Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants