Skip to content

implement the use_debug_value hook #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

implement the use_debug_value hook #566

wants to merge 1 commit into from

Conversation

rmorshea
Copy link
Collaborator

@rmorshea rmorshea commented Jan 5, 2022

part of: #203

@rmorshea rmorshea marked this pull request as draft January 5, 2022 07:56
@@ -392,6 +395,54 @@ def use_ref(initial_value: _StateType) -> Ref[_StateType]:
return _use_const(lambda: Ref(initial_value))


if IDOM_DEBUG_MODE.current:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be cleaner to use a guard statement directly within use_debug_value

def use_debug_value( ... ) 
   if IDOM_DEBUG_MODE.current:
      return
   ...

@rmorshea rmorshea closed this Apr 16, 2022
@rmorshea rmorshea deleted the fix-565 branch April 16, 2022 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants