Skip to content

Rework VDOM construction and type hints #1281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Feb 27, 2025
Merged

Rework VDOM construction and type hints #1281

merged 14 commits into from
Feb 27, 2025

Conversation

Archmonger
Copy link
Contributor

@Archmonger Archmonger commented Feb 23, 2025 •
edited
Loading

Description

  • Removed reactpy.vdom. Use reactpy.Vdom instead.
  • Removed reactpy.core.make_vdom_constructor. Use reactpy.Vdom instead.
  • Removed reactpy.core.custom_vdom_constructor. Use reactpy.Vdom instead.
  • reactpy.html will now automatically flatten lists recursively (ex. reactpy.html(["child1", ["child2"]]))
  • Added type hints to reactpy.html attributes.

Checklist

Please update this checklist as you complete each item:

  • Tests have been developed for bug fixes or new functionality.
  • The changelog has been updated, if necessary.
  • Documentation has been updated, if necessary.
  • GitHub Issues closed by this PR have been linked.

By submitting this pull request I agree that all contributions comply with this project's open source license(s).

@Archmonger Archmonger changed the base branch from main to develop February 23, 2025 08:55
JamesHutchison
JamesHutchison reviewed Feb 24, 2025
View reviewed changes
Copy link
Contributor

@JamesHutchison JamesHutchison left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm presuming the tagName change from first arg to kwarg is about streamlining the dict creation?

looks good

JamesHutchison
JamesHutchison reviewed Feb 24, 2025
View reviewed changes
@Archmonger Archmonger linked an issue Feb 27, 2025 that may be closed by this pull request
reactpy.html does not render nested lists #1280
Closed
@Archmonger Archmonger marked this pull request as ready for review February 27, 2025 12:33
@Archmonger Archmonger merged commit fa48bbc into reactive-python:develop Feb 27, 2025
17 checks passed
@Archmonger Archmonger deleted the v2-new-html-interface branch February 27, 2025 12:42
@Archmonger Archmonger mentioned this pull request Mar 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesHutchison JamesHutchison JamesHutchison left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reactpy.html does not render nested lists
2 participants
@Archmonger @JamesHutchison