Skip to content

script elements can break ReactPy #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Archmonger opened this issue Jan 2, 2023 · 1 comment · Fixed by #1239
Closed

script elements can break ReactPy #867

Archmonger opened this issue Jan 2, 2023 · 1 comment · Fixed by #1239
Labels
priority-2-moderate Should be resolved on a reasonable timeline.

Comments

@Archmonger
Copy link
Contributor

Archmonger commented Jan 2, 2023 •
edited
Loading

Current Situation

If an exception occurs within a script element, ReactPy's renderer is completely stalled.

Proposed Actions

Add error boundaries to prevent the script element from being destructive
@Archmonger Archmonger added type: bug priority-3-low May be resolved one any timeline. labels Jan 2, 2023
@Archmonger Archmonger added this to the 2.0 milestone Jan 2, 2023
@Archmonger
Copy link
Contributor Author

Related issue

@Archmonger Archmonger added priority-2-moderate Should be resolved on a reasonable timeline. and removed priority-3-low May be resolved one any timeline. labels Jan 27, 2023
@Archmonger Archmonger modified the milestones: Luxury, Essential Jan 29, 2023
@rmorshea rmorshea removed this from the Essential milestone Feb 21, 2023
@Archmonger Archmonger changed the title script elements can break IDOM script elements can break ReactPy Jan 21, 2025
@Archmonger Archmonger mentioned this issue Jan 21, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority-2-moderate Should be resolved on a reasonable timeline.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Always render script element as plain HTML Archmonger/reactpy
2 participants
@rmorshea @Archmonger