-
-
Notifications
You must be signed in to change notification settings - Fork 324
Prevent JavaScript components from crashing ReactPy by adding error boundaries #676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I've had this happen once again, despite pinned versions of react bootstrap. A potential solution is naming the files on disk based on a calculated hash, rather than NPM package name. |
Since this can break idom until the user clears his browser cache, I'm going to change the priority/milestone for this. |
@rmorshea This seems to be almost a weekly breaking issue for me, assuming that I'm not clearing cache on each page load. The only way I've found to replicate this issue is very artificial and I'd almost expect it to fail. The less consistent but more realistic way involves me just waiting for it to randomly happen. |
Related to: |
Current Situation
Currently, if an invalid hook call occurs then ReactPy completely breaks.
Reference
Proposed Actions
Add an error boundary to tree nodes to prevent complete failure upon tree exceptions. Probably only want to apply this to things that have been exported via
module_from_template(...)
. We have no reason to assume this exception can happen with any pure ReactPy code.The text was updated successfully, but these errors were encountered: