Skip to content

Fix None within reactpy.html #1025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Archmonger opened this issue Jun 9, 2023 · 0 comments · Fixed by #1171
Closed

Fix None within reactpy.html #1025

Archmonger opened this issue Jun 9, 2023 · 0 comments · Fixed by #1171
Labels
priority-3-low May be resolved one any timeline. release-minor Warrents a minor release type-revision About a change in functionality or behavior

Comments

@Archmonger
Copy link
Contributor

Current Situation

Currently None within reactpy.html elements get rendered as the text literal None, rather than doing nothing.

Tangentially related:

Proposed Actions

We should treat None as a positional placeholder that does nothing. We need to make sure that it doesn't mess up how we auto-generate positional keys.

If we want to handle this server-side, we can substitute it with html._ as a quick-n-easy hack.

@Archmonger Archmonger added priority-3-low May be resolved one any timeline. type-revision About a change in functionality or behavior release-minor Warrents a minor release labels Jun 9, 2023
@Archmonger Archmonger changed the title Allow NoneType returns within reactpy.html Allow None within reactpy.html Jun 9, 2023
@Archmonger Archmonger changed the title Allow None within reactpy.html Fix None within reactpy.html Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-3-low May be resolved one any timeline. release-minor Warrents a minor release type-revision About a change in functionality or behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant