Skip to content

Rename router to browser_router #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Archmonger opened this issue May 10, 2023 · 2 comments · Fixed by #30
Closed

Rename router to browser_router #12

Archmonger opened this issue May 10, 2023 · 2 comments · Fixed by #30

Comments

@Archmonger
Copy link
Contributor

We need to match react-router naming conventions.
@rmorshea
Copy link
Contributor

I'm not really sure our router implementation maps neatly onto what react-router is doing. Making this distinction might make more sense once we have a use_history hook (#8) since that seems to be where the behavior of the different routers diverge.

@Archmonger
Copy link
Contributor Author

Will probably have to have a follow-up issue to think about how closely or how far we diverge from react-router's design.

@Archmonger Archmonger linked a pull request Jun 25, 2024 that will close this issue
Rewrite ReactPy-Router #30
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite ReactPy-Router Archmonger/reactpy-router
2 participants
@rmorshea @Archmonger