-
-
Notifications
You must be signed in to change notification settings - Fork 22
Utilize django include for HTTP URLs #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Archmonger
merged 11 commits into
reactive-python:main
from
Archmonger:rm-idom-path-variable
Jan 21, 2022
Merged
Utilize django include for HTTP URLs #45
Archmonger
merged 11 commits into
reactive-python:main
from
Archmonger:rm-idom-path-variable
Jan 21, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c9e9604
to
0d8640d
Compare
rmorshea
requested changes
Jan 13, 2022
On a tangent, do you think there's a chance we'll ever need more than one websocket endpoint for this repo? If so I can make similar changes on the WS end. Django channels is pretty new so there isn't any good styling guidelines to use for how to accomplish this. |
I don't think so since one WS can serve any number of views. |
rmorshea
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IdomWebsocket
at the module level to encourage type hintingIDOM_BASE_URL
as it was difficult to use in conjunction with Django base URLsWhile this is a breaking change, I don't think mitigations are necessary since it seems like no one besides Conreq is currently using
django-idom
on GitHub.