Skip to content

Utilize django include for HTTP URLs #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 21, 2022

Conversation

Archmonger
Copy link
Contributor

@Archmonger Archmonger commented Jan 12, 2022

While this is a breaking change, I don't think mitigations are necessary since it seems like no one besides Conreq is currently using django-idom on GitHub.

@Archmonger Archmonger marked this pull request as ready for review January 12, 2022 07:39
@Archmonger Archmonger requested a review from a team as a code owner January 12, 2022 07:39
@Archmonger Archmonger force-pushed the rm-idom-path-variable branch from c9e9604 to 0d8640d Compare January 12, 2022 07:55
@Archmonger
Copy link
Contributor Author

Archmonger commented Jan 14, 2022

On a tangent, do you think there's a chance we'll ever need more than one websocket endpoint for this repo?

If so I can make similar changes on the WS end.

Django channels is pretty new so there isn't any good styling guidelines to use for how to accomplish this.

@rmorshea
Copy link
Contributor

rmorshea commented Jan 14, 2022

I don't think so since one WS can serve any number of views.

@Archmonger Archmonger requested a review from rmorshea January 20, 2022 08:17
@Archmonger Archmonger merged commit 2e7dcf6 into reactive-python:main Jan 21, 2022
@Archmonger Archmonger deleted the rm-idom-path-variable branch January 21, 2022 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix antipattern with IDOM_WEB_MODULE_PATH
2 participants