-
-
Notifications
You must be signed in to change notification settings - Fork 22
Auto populate IDOM component registry #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto populate IDOM component registry #24
Conversation
The only caveat to this design is it seems to inconsistently break |
Converting to draft while I debug django-silk compatibility |
It was too much of a hassle to PR a fix for This implementation should be functionally equivalent. |
I resolved the two comments, and additionally I've created a Django mandates this test folder naming scheme, but it does feel a bit awkward though since our test project is also called |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM besides a few more minor nits
Once we get this in I think we can do a release if the threading issue is gonna take a while to resolve. |
Completed! |
When Django first loads, attempt to populate the IDOM component registry.
This design was inspired by
django_compressor
. See https://github.com/idom-team/django-idom/discussions/20 for more details.