Skip to content

use_root_id hook #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Feb 21, 2024
Merged

use_root_id hook #230

merged 15 commits into from
Feb 21, 2024

Conversation

Archmonger
Copy link
Contributor

@Archmonger Archmonger commented Feb 20, 2024 •
edited
Loading

Description

Create a use_root_id hook that fetches this value from the websocket or HTTP connection

  • fix use_root_id hook #203
  • Some miscellaneous refactoring on the websocket consumer and UserDataModel, just because I happened to notice some cleanup potential while making this PR.

Checklist

Please update this checklist as you complete each item:

  • Tests have been developed for bug fixes or new functionality.
  • The changelog has been updated, if necessary.
  • Documentation has been updated, if necessary.
  • GitHub Issues closed by this PR have been linked.

By submitting this pull request I agree that all contributions comply with this project's open source license(s).

@Archmonger Archmonger marked this pull request as ready for review February 21, 2024 01:29
@Archmonger Archmonger requested a review from a team as a code owner February 21, 2024 01:29
@Archmonger Archmonger merged commit c4e55b3 into reactive-python:main Feb 21, 2024
@Archmonger Archmonger deleted the use-root-id branch February 21, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use_root_id hook
1 participant
@Archmonger