Skip to content

Use NodeJS-bin instead of the user's node install #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

Archmonger
Copy link
Contributor

@Archmonger Archmonger commented Jan 9, 2024

Description

Our test suite currently relies on the user manually installing NodeJS in order for npm commands to be run.

This is an error prone process with way to control what npm version the end-user has. This method also can also fail due to missing PATH variables.

This PR uses premade binaries for npm instead of the user's local npm installation.

Checklist:

Please update this checklist as you complete each item:

  • Tests have been developed for bug fixes or new functionality.
  • The changelog has been updated, if necessary.
  • Documentation has been updated, if necessary.
  • GitHub Issues closed by this PR have been linked.

By submitting this pull request you agree that all contributions comply with this project's open source license(s).

@Archmonger Archmonger requested a review from a team as a code owner January 9, 2024 07:13
@Archmonger
Copy link
Contributor Author

FYI @rmorshea

NodeJS-Bin seems pretty nice to me. It's a bit unfortunate the author stopped posting version updates beyond 18.x, but for our purposes 18.x works.

@Archmonger Archmonger merged commit 6fb7ba2 into reactive-python:main Jan 9, 2024
@Archmonger Archmonger deleted the use-nodejs-bin branch January 9, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant