Skip to content

v3.3.1 #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 9, 2023
Merged

v3.3.1 #169

merged 3 commits into from
Aug 9, 2023

Conversation

Archmonger
Copy link
Contributor

@Archmonger Archmonger commented Aug 9, 2023 •
edited
Loading

By submitting this pull request you agree that all contributions to this project are made under the MIT license.

Description

  • Default REACTPY_BACKHAUL_THREAD to False since there may be a negative performance impact in some edge cases
    • Likely caused by the consumer's receive function is awaited on the main thread, but our layout logic is run on the backhaul thread.
    • I'll need to do some digging, but it's possible this can't be resolved without replacing our Channels consumer with an generic ASGI app.
  • Add some more checks
  • Run ruff formatter on all python files
  • Fix some typos in the docs

@Archmonger Archmonger requested a review from a team as a code owner August 9, 2023 00:22
@Archmonger Archmonger merged commit 36da02e into reactive-python:main Aug 9, 2023
@Archmonger Archmonger deleted the 3.3.1 branch August 9, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Archmonger