Skip to content

v2.2.1: Fix recursive fetch depth for ManyToOneRel #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 9, 2023
Merged

v2.2.1: Fix recursive fetch depth for ManyToOneRel #117

merged 9 commits into from
Jan 9, 2023

Conversation

Archmonger
Copy link
Contributor

@Archmonger Archmonger commented Jan 2, 2023 •
edited
Loading

Description

Recursive fetching was only ocurring on ManyToManyField. This PR makes the recursive call occur for both ManyToOneRel and ManyToManyField.

Changelog

Checklist:

Please update this checklist as you complete each item:

  • Tests have been included for all bug fixes or added functionality.
  • The changelog has been updated with any significant changes, if necessary.
  • GitHub Issues which may be closed by this PR have been linked.

@Archmonger Archmonger linked an issue Jan 2, 2023 that may be closed by this pull request
use_query ManyToMany fetching sometimes fails #116
Closed
@Archmonger Archmonger marked this pull request as ready for review January 2, 2023 07:57
@Archmonger Archmonger requested a review from rmorshea January 2, 2023 07:57
@Archmonger Archmonger changed the title Fix recursive fetch depth for ManyToOneRel v2.2.1: Fix recursive fetch depth for ManyToOneRel Jan 2, 2023
@Archmonger
Copy link
Contributor Author

Archmonger commented Jan 9, 2023 •
edited
Loading

@rmorshea can we merge this?

Will push this version bump out then work on #118

Alternatively, I can pull out the 2.2.1 version bump from this PR.

@Archmonger Archmonger merged commit 62ea6f1 into reactive-python:main Jan 9, 2023
@Archmonger Archmonger deleted the fix-use-query-recursive branch January 9, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmorshea rmorshea rmorshea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use_query ManyToMany fetching sometimes fails
2 participants
@Archmonger @rmorshea