Add Netty codec samples, unit tests, and improve build JDK version settings #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here is the JDK level policy enforced by the Gradle build: * in core modules, sources should be JDK 1.7 compatible * in core modules, tests should be JDK1.8 compatible * in example modules, sources+tests should be JDK 1.8 compatible This commit fixes the gradle build configuration and a missing `final` keyword in a core implementation class. This change also switch the `reactor-net` dependency to a `reactor-stream` dep.
Fix JDK source/target levels in projects
Fixes #34
Closed
|
This PR now also contains the unit tests commit |
rstoyanchev
changed the title
…ready Publishers.just Move Publishers to common test dependency ripc-test
smaldini
added a commit
that referenced
this pull request
Jul 6, 2015
Add Netty codec samples, unit tests, and improve build JDK version settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds sample code with Netty codecs to help with #28.
One example uses Netty's LineBasedFrameDecoder to split the input stream into messages based on new line characters. Another example uses Netty's JsonObjectDecoder to split the input stream by matching curly braces + a simple Jakson-based custom decoder for actually decoding the JSON.
Both examples request one 1 item at a time and also allow configuring Netty's input buffer size to experiment with the effect of calls to channel.read. A separate PR will be sent short with example read backpressure support for discussion and comments will be added under #28.
The PR also includes a couple more minor changes: