Skip to content

build(ci): Improve Android e2e #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 8, 2022
Merged

build(ci): Improve Android e2e #828

merged 2 commits into from
Aug 8, 2022

Conversation

krizzu
Copy link
Member

@krizzu krizzu commented Aug 4, 2022

Summary

Bumping few bits in our CircleCI config. Using Linux machine instead of macos to run Android e2e. Using Test Butler to make sure e2e goes smoothly.

Test Plan

Green CI

@krizzu krizzu marked this pull request as ready for review August 4, 2022 14:10
tido64
tido64 reviewed Aug 4, 2022
View reviewed changes
.circleci/config.yml Outdated
- image: reactnativecommunity/react-native-android
resource_class: 'medium'
working_directory: ~/async_storage
- image: cimg/android:2021.10.2-node # node 14.18.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this also use cimg/node:14.18.1 as above? Or android:2022.06.2?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image has Android SDK preinstalled, and is used to create an apk for tests. I could merge the apk creation into e2e job, since it's no longer macos.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a cost to spinning up a separate machine? I'd imagine we should stay on the same machine for as long as possible, but I don't know how CircleCI works.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's no cost for boot up, but rather the overall execution time.

tido64
tido64 approved these changes Aug 7, 2022
View reviewed changes
Copy link
Member

@tido64 tido64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like for CI to use less machines to make the config easier to maintain. But if we intend to migrate to GitHub Actions anyway, maybe it's fine for now.

@krizzu
Copy link
Member Author

krizzu commented Aug 8, 2022

I'd like for CI to use less machines to make the config easier to maintain. But if we intend to migrate to GitHub Actions anyway, maybe it's fine for now.

I changed the config to use one executor for Android, that should simplify this a bit 👍

@krizzu krizzu merged commit 49dea24 into master Aug 8, 2022
@krizzu krizzu deleted the ci/enhancements branch August 8, 2022 09:19
@krizzu
Copy link
Member Author

krizzu commented Aug 8, 2022

🎉 This PR is included in version 1.17.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@krizzu krizzu added the released label Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tido64 tido64 tido64 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krizzu @tido64