Skip to content

ci: bump react-native-test-app to 1.1.4 #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2022
Merged

ci: bump react-native-test-app to 1.1.4 #763

merged 1 commit into from
Mar 4, 2022

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Mar 1, 2022

Summary

Bumps react-native-test-app to 1.1.4 to fix issues with Address and Undefined Behavior sanitizers.

Test Plan

CI should pass.

@tido64 tido64 requested a review from krizzu March 1, 2022 13:32
@tido64 tido64 marked this pull request as ready for review March 1, 2022 13:32
@tido64
Copy link
Member Author

tido64 commented Mar 3, 2022

@krizzu: Can you review this whenever you have some free cycles? Thanks 😄

Comment on lines -8 to -12
IOS_XCSCHEME="node_modules/.generated/ios/ReactTestApp.xcodeproj/xcshareddata/xcschemes/ReactTestApp.xcscheme"

# Disable Address Sanitizer as it crashes Detox
sed -i '' 's/enableAddressSanitizer = "YES"/enableAddressSanitizer = "NO"/g' "$IOS_XCSCHEME"
sed -i '' 's/enableUBSanitizer = "YES"/enableUBSanitizer = "NO"/g' "$IOS_XCSCHEME"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@tido64 tido64 merged commit 07fcbf1 into master Mar 4, 2022
@tido64 tido64 deleted the tido/bump-rnta branch March 4, 2022 10:53
@krizzu
Copy link
Member

krizzu commented Mar 15, 2022

🎉 This PR is included in version 1.16.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants