chore: bump react-native to 0.66 #757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@krizzu: Can you review this whenever you have some free cycles? Thanks 😄 |
krizzu
reviewed
Mar 15, 2022
| }; | ||
| project: { | ||
| android: { | ||
| sourceDir: path.join('example', 'android'), |
There was a problem hiding this comment.
q: does this allow us to remove root option from run-android script?
krizzu
reviewed
Mar 15, 2022
| ), | ||
| ), | ||
| }, | ||
| ios: { |
There was a problem hiding this comment.
Because we specify options in start:macos script, we don't have to add this target here, right?
There was a problem hiding this comment.
react-native-macos doesn't use this field, I think. They look for the project independent of the cli config.
krizzu
reviewed
Mar 15, 2022
react-native.config.js
Outdated
Comment on lines
62
to
65
| packageSatisfiesVersionRange( | ||
| '@react-native-community/cli-platform-ios', | ||
| '<5.0.2', | ||
| ) |
krizzu
approved these changes
Mar 15, 2022
tido64
force-pushed
the
tido/bump-react-native
branch
from
3810aeb to
7fe2b59
Compare
tido64
force-pushed
the
tido/bump-react-native
branch
from
7fe2b59 to
2eace8e
Compare
|
🎉 This PR is included in version 1.16.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bump react-native to 0.66
Test Plan
CI should pass.