chore: migrate example app to TypeScript #721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When upgrading Flow (from upgrading react-native), a bunch of errors come from the test app. Taking this opportunity to migrate to TypeScript to avoid future issues. Next up would be to convert the rest of the Flow files.
tido64
force-pushed
the
tido/migrate-example-typescript
branch
from
e9cee73 to
1a1d7a8
Compare
krizzu
reviewed
Dec 1, 2021
|
🎉 This PR is included in version 1.15.15 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When upgrading Flow (from upgrading react-native), a bunch of errors come from the test app (see build log). Taking this opportunity to migrate to TypeScript to avoid future issues.
Next up would be to convert the rest of the Flow files.
Test Plan
CI should pass.