Skip to content

docs(website): update auto-linking info for macOS #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

mmazzarolo
Copy link
Contributor

@mmazzarolo mmazzarolo commented Sep 22, 2021

Since React Native for macOS 0.63, autolink works out-of-the-box as long as platform :macos, '10.14' is set in Podfile)

See #587

Since React Native for macOS 0.63, autolink works (as long as `platform :macos, '10.14'` is set in Podfile

See react-native-async-storage#587
@mmazzarolo
Copy link
Contributor Author

I assume CI failing here is not related to the PR changes, right?

@krizzu krizzu requested a review from tido64 September 27, 2021 10:58
@krizzu
Copy link
Member

krizzu commented Sep 27, 2021

No, it's not. CircleCI has some issues currently, so maybe that's why Android unit test fails. Regarding Windows, maybe @tido64 would have an idea.

Anyway, I'm happy to merge it - @tido64 might having a look as well? 🙏🏼

@tido64
Copy link
Member

tido64 commented Sep 27, 2021

No, it's not. CircleCI has some issues currently, so maybe that's why Android unit test fails. Regarding Windows, maybe @tido64 would have an idea.

No idea what's going on. Looks like it could be some caching issue? Not seeing this on master. In any case, let's just force merge this while we figure it out.

@tido64 tido64 merged commit e99edf0 into react-native-async-storage:master Sep 27, 2021
@mmazzarolo mmazzarolo deleted the patch-1 branch September 28, 2021 13:55
@krizzu
Copy link
Member

krizzu commented Oct 5, 2021

🎉 This PR is included in version 1.15.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

@krizzu krizzu added the released label Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants