Skip to content

Update Java example for Brownfield integration #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 12, 2021

Conversation

vtoupet
Copy link
Contributor

@vtoupet vtoupet commented Apr 9, 2021

Summary

Java example for Android Brownfield integration is not up-to-date based on the current implementation of the next-storage (Androidx Room usage).

Test Plan

Copy link
Member

@krizzu krizzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Couple of small things and it's ready to go

Comment on lines 230 to 231
List<String> keys = new ArrayList<>();
keys.add("kkk");
Copy link
Member

@krizzu krizzu Apr 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove those two lines, as they're not used

@krizzu
Copy link
Member

krizzu commented Apr 12, 2021

@vtoupet there are two other lines that need to be removed, then this is ready to go

Copy link
Member

@krizzu krizzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@krizzu krizzu merged commit 76bdcfd into react-native-async-storage:master Apr 12, 2021
@krizzu
Copy link
Member

krizzu commented Apr 21, 2021

🎉 This PR is included in version 1.15.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants