-
Notifications
You must be signed in to change notification settings - Fork 476
Update Java example for Brownfield integration #583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Couple of small things and it's ready to go
List<String> keys = new ArrayList<>(); | ||
keys.add("kkk"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove those two lines, as they're not used
Co-authored-by: Krzysztof <[email protected]>
Co-authored-by: Krzysztof <[email protected]>
@vtoupet there are two other lines that need to be removed, then this is ready to go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
🎉 This PR is included in version 1.15.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
Java example for Android Brownfield integration is not up-to-date based on the current implementation of the next-storage (Androidx Room usage).
Test Plan