Update Java example for Brownfield integration #583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
krizzu
reviewed
Apr 9, 2021
Comment on lines
230
to
231
| List<String> keys = new ArrayList<>(); | ||
| keys.add("kkk"); |
There was a problem hiding this comment.
You can remove those two lines, as they're not used
Co-authored-by: Krzysztof <[email protected]>
Co-authored-by: Krzysztof <[email protected]>
|
@vtoupet there are two other lines that need to be removed, then this is ready to go |
|
🎉 This PR is included in version 1.15.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Java example for Android Brownfield integration is not up-to-date based on the current implementation of the next-storage (Androidx Room usage).
Test Plan