Skip to content

[docs] Update to Installation Page #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

calebnance
Copy link
Contributor

Summary

Broke out the 2 different ways to install (NPM or Yarn) to be one-liners, so that the "copy code" functionality is helpful.

Currently when clicking the copy code from the code block, it copies both NPM and Yarn. This change just breaks them out for a quick one line copy depending on the developer's need.

Before After
Screen Shot 2021-02-16 at 3 22 52 PM Screen Shot 2021-02-16 at 3 23 00 PM

Test Plan

Screenshots above shows the before and after.

Copy link
Member

@tido64 tido64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for caring about this ❤️

@calebnance
Copy link
Contributor Author

@tido64 of course, have a great week!

@krizzu
Copy link
Member

krizzu commented Feb 18, 2021

thanks @calebnance ! If you could look into comments left, that'd be awesome 👍

@calebnance
Copy link
Contributor Author

@krizzu Thanks, I updated the PR

@krizzu krizzu merged commit c7f61aa into react-native-async-storage:master Feb 18, 2021
@krizzu
Copy link
Member

krizzu commented Feb 18, 2021

Thanks a lot

@krizzu
Copy link
Member

krizzu commented Feb 22, 2021

🎉 This PR is included in version 1.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants