Skip to content

Native Module refreshment #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Native Module refreshment #408

wants to merge 3 commits into from

Conversation

krizzu
Copy link
Member

@krizzu krizzu commented Jul 27, 2020

Summary:

Here comes the time to refresh the Native Module used by Android. Instead using error prone SQLiteOpenHelper, Room + Coroutines are used. This will help with dealing with all regarding accessing db and ease implementation of new features, such as accessing DB from Native Side and others.

Todo Plan:

  • Match API for JS module
  • Implement Merge/mutliMerge API on JS side for new module
  • Replace old Native Android module with this new one
  • Refresh Example App
  • Write unit tests for native and js module (add them to CI)
  • Add other todo I forgot

Test Plan:

  1. Green UI tests
  2. Would be great to have integration tests too 🤞

@krizzu krizzu added the platform: Android This is Android specific label Jul 27, 2020
@krizzu krizzu force-pushed the android-native-rebuild branch from 837b1b1 to 9553145 Compare August 6, 2020 21:09
@krizzu krizzu force-pushed the android-native-rebuild branch from 9553145 to e5244c2 Compare August 7, 2020 06:44
@krizzu
Copy link
Member Author

krizzu commented Oct 7, 2020

Closing, will re-open when AsyncStorage is moved to separate org

@krizzu krizzu closed this Oct 7, 2020
@krizzu krizzu deleted the android-native-rebuild branch January 18, 2021 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: Android This is Android specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant