Skip to content

TypeScript support #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 8, 2019
Merged

TypeScript support #28

merged 2 commits into from
Mar 8, 2019

Conversation

itsjgf
Copy link
Contributor

@itsjgf itsjgf commented Mar 1, 2019

Closes #27.

@krizzu krizzu added the enhancement New feature or request label Mar 4, 2019
@krizzu
Copy link
Member

krizzu commented Mar 4, 2019

Hey @itsjgf, thanks for this PR!

This looks good. We're missing types for our hooks implementation - could you add them too?

Also, please move this file to types/index.d.ts and update package.json to have "types": "./types/index.d.ts".

Thanks!

@itsjgf
Copy link
Contributor Author

itsjgf commented Mar 4, 2019

@krizzu done!

@krizzu krizzu changed the title feat: add TypeScript support TypeScript support Mar 5, 2019
krizzu
krizzu approved these changes Mar 7, 2019
View reviewed changes
Copy link
Member

@krizzu krizzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You @itsjgf !

@krizzu krizzu merged commit 67ae214 into react-native-async-storage:master Mar 8, 2019
@danilobuerger
Copy link
Contributor

@krizzu Would it be possible to get a release with this soon?

@krizzu
Copy link
Member

krizzu commented Mar 8, 2019

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@krizzu krizzu added the Released label Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krizzu krizzu krizzu approved these changes

@Esemesek Esemesek Esemesek approved these changes

Assignees

@itsjgf itsjgf

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@itsjgf @krizzu @danilobuerger @Esemesek