Skip to content

chore: fix tsc not checking src/* #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2023
Merged

chore: fix tsc not checking src/* #1035

merged 1 commit into from
Nov 28, 2023

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Nov 28, 2023

Summary

main currently fails because of TypeScript errors not picked up during PR.

Test Plan

CI should pass.

@tido64 tido64 requested a review from krizzu as a code owner November 28, 2023 21:35
@krizzu krizzu mentioned this pull request Nov 28, 2023
Copy link
Member

@krizzu krizzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could move prettier to the root, but otherwise looks good 👍

@tido64 tido64 merged commit 44f696c into main Nov 28, 2023
@tido64 tido64 deleted the tido/fix-typescript branch November 28, 2023 22:39
@AsyncStorageBot
Copy link
Collaborator

🎉 This PR is included in version 1.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants