chore: Scaffold Core repo #1006
Conversation
| { | ||
| "tabWidth": 2, | ||
| "semi": true, | ||
| "singleQuote": true, | ||
| "bracketSpacing": true, | ||
| "parser": "typescript" | ||
| } |
There was a problem hiding this comment.
I'd love to remove this config at some point and just use whatever default Prettier uses.
There was a problem hiding this comment.
I just checked and removing this config would replace all single quotes with doubles. If you don't mind, I can do this in this PR
There was a problem hiding this comment.
Let's do it in a separate PR. I think we want to upgrade to 3.x as well.
packages/core/package.json
Outdated
| "main": "lib/commonjs/index", | ||
| "module": "lib/module/index", | ||
| "types": "lib/typescript/index.d.ts", | ||
| "react-native": "src/index", | ||
| "source": "src/index", |
There was a problem hiding this comment.
We should also include an exports map. Metro started supporting it recently.
Also, why are we missing the extensions? Platform forking is not applied to entry point files regardless.
There was a problem hiding this comment.
I copied this from bob setup, so there was no file ext.
TIL about exports 😄 replaced it now
There was a problem hiding this comment.
Since this is only used as base, can we move it into a .config folder to hide the clutter in root?
There was a problem hiding this comment.
I would opt out of doing that, as this might decrease DX. IDE like Webstorm picks those config files and enables support based on their existence
There was a problem hiding this comment.
Webstorm doesn't pick the nearest config?
There was a problem hiding this comment.
You're right! I had problem with monorepo and diff eslint on Webstorm in other project, but the quick check proved it picks the nearest config!
| "eslint-plugin-wdio": "^8.8.7", | ||
| "expo": "^48.0.0", | ||
| "lodash": "^4.17.21", | ||
| "prettier": "^2.5.1", | ||
| "prettier": "2.4.1", |
There was a problem hiding this comment.
Why did we roll back to an older version?
There was a problem hiding this comment.
I meant to unify the versions from core and this package. Installed 2.5.1 instead.
|
@tido64 thanks for review 🙏 I'll do another PR with Prettier upgrade and moving of config files |
|
🎉 This PR is included in version 1.19.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
A basic setup for Core repo. Typescript and Eslint config are in roots, extended by workspaces.