-
Notifications
You must be signed in to change notification settings - Fork 475
Recent 1.3.1 release breaks iOS build if linked with pods #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Open |
Summary: --------- Multiple people have reported that RNCAsyncStorage fails to build after #35. See #35 (comment), #73, and #74. After a little discussion, we agreed to rename the `.podspec` and the name of the Pod to be more in line with Apple's naming guidelines and the rest of the community. Unfortunately, this means that the next upgrade will break. I got a little impatient knowing that I broke the latest release so I went ahead and implemented the fix. Sorry if you've already started looking at this. Migration Plan: --------------- Even though `react-native link` will be able to link the new `.podspec`, it won't clean up existing entries. Please find your Podfile, and make the following changes: ```diff - pod 'react-native-async-storage', :path => '../node_modules/@react-native-community/async-storage' + pod 'RNCAsyncStorage', :path => '../node_modules/@react-native-community/async-storage' ```
Merged and released as 1.3.2: #75 (comment). Thanks, everyone ❤️ Let us know how you go. |
I have tried to build without this module and it's working. I don't know, what is the fix for this. I am using latest version. Its working if I am modifying file - RNCAsyncStorage.h. But getting error with other components I have tried to manual linking and auto linking. Anyone having same issue ? "@react-native-community/async-storage": "^1.4.1", |
@codoffer I am also getting an error when I build without pods -- I get this error
If i do the changes @dblazeski recommends (except I change the line to Manual linking and auto linking don't work, only changing that line in "@react-native-community/async-storage": "1.4.2", |
Yes, you are right. But its temporary fix. It was working fine before, On update of my node_modules, facing these issues. |
Hitting this bug on 1.4.2 and this seems to solve it for me. Are there any more people still facing this issue? |
Uh oh!
There was an error while loading. Please reload this page.
Repro steps
I've created an example app at https://github.com/timmywil/react-native-async-storage-1.3.1
This app was created with
react-native init
and async-storage included withreact-native link... && cd ios/ && pod install
after creating a Podfile.Building without pods seems to work fine, but if async-storage is included with pods, you get the error shown above.
Downgrading to 1.3.0 fixes the issue.
Environment
The text was updated successfully, but these errors were encountered: