-
Notifications
You must be signed in to change notification settings - Fork 163
Remove extraneous dependencies. #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LGTM |
Weren't those used for the visual test? |
Nope. There were in no use at all. |
Wait, it looks like they were: https://github.com/react-bootstrap/react-router-bootstrap/blob/v0.17.2/tests/visual.js - this is trying to import a LESS file. |
Yeah. But |
The same history as with |
It looks like that: (before we removed those unused deps) then I open in browser http://localhost:8080/webpack-dev-server/ See ? Nothing. Broken. |
I recently fixed those in #85 so they should be working. |
Alas, nope :) |
Neither of those urls are the visual test. You should hit: http://localhost:8080/public/visual#/ |
For example the url: http://localhost:8080/public/visual#/button Should look like: Instead with this change it's blank and you'll see the console output:
|
You want me to run me down by this loooong console output 😄 I got it. Tomorrow I'll fix this all ⛵ |
That's partly my fault for not putting that link somewhere. I thought at some point along the line it was addressed, but I guess not. My apologies. |
No description provided.