Skip to content

Get rid of RouterOverlayTrigger and RouterModalTrigger #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
taion opened this issue Jun 11, 2015 · 4 comments
Closed

Get rid of RouterOverlayTrigger and RouterModalTrigger #77

taion opened this issue Jun 11, 2015 · 4 comments
Milestone
React 0.14

Comments

@taion
Copy link
Member

taion commented Jun 11, 2015

Per react-bootstrap/react-bootstrap#811 (comment)

These won't actually be needed for React v0.14.
taion added a commit that referenced this issue Jun 11, 2015
@taion
[removed] Remove docs for router context triggers
549a3fd 
Don't encourage their use, since they will be deprecated

For #77
@mtscout6
Copy link
Member

You sure that you want to remove this before 0.14 is out? Is there anybody that's using it at the moment. I'm fine with creating an issue and a React 0.14 milestone if that's the case.

@taion
Copy link
Member Author

taion commented Jun 12, 2015

Oops, should have been more clear - I should have done more research before adding those two components, but I agree that we can't remove them until React v0.14 is out. I just wanted to get rid of the docs right now to minimize the number of users for when we do deprecate those components.

@mtscout6 mtscout6 added this to the React 0.14 milestone Jun 12, 2015
@taion
Copy link
Member Author

taion commented Jul 22, 2015

#98 gets us halfway there.

@taion taion mentioned this issue Aug 13, 2015
Merged
@taion
Copy link
Member Author

taion commented Sep 15, 2015

f911799

@taion taion closed this as completed Sep 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
React 0.14
Development

No branches or pull requests
2 participants
@mtscout6 @taion