-
Notifications
You must be signed in to change notification settings - Fork 219
feat!: Make DropdownAPI consistent and fix keyboard handling #843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
} | ||
|
||
function useRefWithUpdate() { | ||
const forceUpdate = useForceUpdate(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: do these get properly enqueued/deduped, or could we end up with a double-rerender?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fairly sure it does, maybe not a big deal either way idk
I realized recently that we don't handle Should try and attach the events in react via props? I was trying to avoid extra event merging needed by users, but maybe that's ok here? Alternatively i could do the capture phase tagging etc |
ohh that's unfortunate. these don't even both go through root close wrapper, right? i guess we could have some shared |
Also removes the need for a wrapping element
6b1be76
to
cb4f2ad
Compare
cb4f2ad
to
a668208
Compare
Also removes the need for a wrapping element