Skip to content

Notify SAC when it is no longer active #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

acogoluegnes
Copy link
Contributor

A single active consumer may not always receive a notification from the broker when it gets inactive. An obvious reason is the consumer connection goes down. It is still possible to call the consumer update listener from the library, which can help applications take an appropriate action when a consumer goes from active to inactive.

This commit implements the call to the listener under such circumstances (connection closed, stream unavailable because restarted, normal consumer closing).

A single active consumer may not always receive a notification from the
broker when it gets inactive. An obvious reason is the consumer
connection goes down. It is still possible to call the consumer update
listener from the library, which can help applications take an
appropriate action when a consumer goes from active to inactive.

This commit implements the call to the listener under such circumstances
(connection closed, stream unavailable because restarted, normal
consumer closing).
@acogoluegnes acogoluegnes marked this pull request as ready for review September 23, 2024 15:53
@acogoluegnes acogoluegnes added this to the 0.18.0 milestone Sep 23, 2024
@acogoluegnes acogoluegnes merged commit 64b4051 into main Sep 23, 2024
3 checks passed
@acogoluegnes acogoluegnes deleted the notify-sac-it-is-no-longer-active branch September 23, 2024 15:54
github-actions bot pushed a commit that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant