Force localhost for local development #420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is when the initial host is localhost, the user is guest and no address resolver has been provided. This should prevent some difficulties met during the first local experiments with RabbitMQ Streams. See spring-projects/spring-amqp#2522
michaelklishin
approved these changes
Sep 15, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Sep 15, 2023
…opment Force localhost for local development
|
For tracking, here's the same PR for the .NET stream client: rabbitmq/rabbitmq-stream-dotnet-client#305. |
acogoluegnes
added a commit
that referenced
this pull request
Nov 4, 2024
The dev mode is activated when no address resolver is set, the host is localhost, and the user is guest. The dev mode sets a resolver that always uses localhost, this avoids problems when e.g. the metadata frame returns the hostname of a local container that the client application cannot reach. This commit adds a warn-level log message if the client detects a local cluster setup (because there are several addresses passed in to the address resolver). References #420
github-actions bot
pushed a commit
that referenced
this pull request
Nov 4, 2024
The dev mode is activated when no address resolver is set, the host is localhost, and the user is guest. The dev mode sets a resolver that always uses localhost, this avoids problems when e.g. the metadata frame returns the hostname of a local container that the client application cannot reach. This commit adds a warn-level log message if the client detects a local cluster setup (because there are several addresses passed in to the address resolver). References #420
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is when the initial host is localhost, the user is guest and no address resolver has been provided.
This should prevent some difficulties met during the first local experiments with RabbitMQ Streams.
See spring-projects/spring-amqp#2522