Skip to content

Consider revising credit default higher #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michaelklishin opened this issue Apr 26, 2025 · 0 comments
Open

Consider revising credit default higher #751

michaelklishin opened this issue Apr 26, 2025 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@michaelklishin
Copy link
Contributor

Is your feature request related to a problem? Please describe.

This is neither a bug nor a feature request but it can potentially safe some confusion.

In #750, you can see that a couple of unacknowledged message values, namely 100 but also 10,
produce a surprising message rate drop.

Digging in has led me to

  1. Discover that ProducerBuilder#batchSize defaults to 100
  2. Dynamic batching Add dynamic-batch publishing option #649
  3. Dynamic batching enabled by default in recent versions Use dynamic batch publishing by default #671

All of those improvements are great but we might have to revisit some of our batching- and credits-related defaults because regardless of how impractical (considering the kind of throughput streams can handle when they are not resource-constrained), a maximum unacknowledged value of 10 is still a setting someone might choose to compare.

Describe the solution you'd like

Perhaps the default credit should match the default batch size, that is, be set to 100? Or both should be set to 1000 by default?

Stream PerfTest uses 20K for its default.

Describe alternatives you've considered

No response

Additional context

See #750.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants