Skip to content

Fixing Endpoint passed to StreamSystem #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

TroelsL
Copy link
Contributor

@TroelsL TroelsL commented Sep 28, 2023

This fix ensures that the clientParams passed to the StreamSystem matches the one set on the Client (and the one the connection has just been established to).

Fixes an issue where the server is bound to multiple IPs, and it advertises a local IP address over a public one.

Resolves: #315

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a2e06bf) 92.79% compared to head (aa87f14) 92.69%.

❗ Current head aa87f14 differs from pull request most recent head 748cc9d. Consider uploading reports for the commit 748cc9d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
- Coverage   92.79%   92.69%   -0.11%     
==========================================
  Files         112      112              
  Lines        9804     9805       +1     
  Branches      785      785              
==========================================
- Hits         9098     9089       -9     
- Misses        536      544       +8     
- Partials      170      172       +2     
Files Coverage Δ
RabbitMQ.Stream.Client/StreamSystem.cs 81.69% <100.00%> (+0.06%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gsantomaggio
Copy link
Member

Thank you @TroelsL we are looking on it

@Gsantomaggio Gsantomaggio self-requested a review September 29, 2023 09:27
@Gsantomaggio Gsantomaggio self-assigned this Sep 29, 2023
@Gsantomaggio
Copy link
Member

It looks good to me, but I'd like to hear @Zerpet, who recently worked on #305, and I'd like to understand if there is any side effect.

The endpoint is not passed since it is filled when there is the query metadata.

@TroelsL
Copy link
Contributor Author

TroelsL commented Sep 29, 2023

Closing this PR due to a false positive. The change here will have no effect on the current implementation as the value passed set on ClientParameters.EndPoint in the context of StreamSystem is never used.

@TroelsL TroelsL closed this Sep 29, 2023
@TroelsL TroelsL deleted the fix-endpoint-on-stream-system branch September 29, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing incorrect value to StreamSystem during creation.
2 participants