Skip to content

Parse unsigned byte B in ValueReader #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

ByteAlex
Copy link
Contributor

@ByteAlex ByteAlex commented Nov 5, 2021

Proposed Changes

This PR fixes #713 and implement's the type B as shown supported in this document.

Types of Changes

  • Bugfix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Further Comments

Since this is a trivial change, I've not bothered to make the thing compile on my M1. As soon as I have my usual development environment available again, I'll run the tests and update this PR if necessary.

A question in regards to

I have added tests that prove my fix is effective or that my feature works

I have looked into the test files for the given method, but this method was not explicitly tested against all types, so I concluded that a test for my PR/fix would not be needed. Is that correct?

@michaelklishin michaelklishin merged commit 0f2a53e into rabbitmq:main Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unsigned 8 bit number field type seems not to be supported
2 participants