Parse unsigned byte B
in ValueReader
#714
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR fixes #713 and implement's the type
B
as shown supported in this document.Types of Changes
Checklist
CONTRIBUTING.md
documentFurther Comments
Since this is a trivial change, I've not bothered to make the thing compile on my M1. As soon as I have my usual development environment available again, I'll run the tests and update this PR if necessary.
A question in regards to
I have looked into the test files for the given method, but this method was not explicitly tested against all types, so I concluded that a test for my PR/fix would not be needed. Is that correct?