Add lambda-based methods to consume messages #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only basic.deliver and basic.cancel callbacks are covered. They're likely to be the most commonly used. This can provide a straightforward syntax when callbacks are simple (e.g. one line). The Delivery wrapper class from RpcServer has been extracted as a top level class: it's used in the deliver callback to avoid having a lambda with 4 parameters. Fixes #247
jplock
reviewed
Feb 28, 2017
| */ | ||
| public byte[] getBody() { | ||
| return _body; | ||
| } |
There was a problem hiding this comment.
Can equals and hashCode be defined in here to support mocking? The same question could be said for https://github.com/rabbitmq/rabbitmq-java-client/blob/master/src/main/java/com/rabbitmq/client/Return.java which was recently added.
There was a problem hiding this comment.
I think that's a good idea but we can do it in a follow-up PR (feel free to look into a pull request ;))
There was a problem hiding this comment.
Sounds good, I'll try and put one together.
michaelklishin
approved these changes
Mar 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only basic.deliver and basic.cancel callbacks are covered.
They're likely to be the most commonly used. This can provide
a straightforward syntax when callbacks are simple (e.g. one line).
The Delivery wrapper class from RpcServer has been extracted as
a top level class: it's used in the deliver callback to avoid
having a lambda with 4 parameters.
Fixes #247