Prevent deadlock/hanging on JDK socket write #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@acogoluegnes thanks. We can do this for 4.0 but we really should switch to NIO in the medium term in my opinion. |
|
@acogoluegnes it looks reasonable at first glance. |
Use the shutdown executor only if it's been set. Fixes #194
acogoluegnes
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a timeout do some shutdown operations as they can deadlock (mainly because JDK sockets don't support a timeout on write operations). This can solve the problem which gave birth to #11, and thus avoids a complete NIO2 rewrite.
Fixes #194
References #11