Skip to content

Spurious warnings emitted by ClientVersion when the library is relocated #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
astei opened this issue Dec 26, 2018 · 1 comment · Fixed by #437
Closed

Spurious warnings emitted by ClientVersion when the library is relocated #436

astei opened this issue Dec 26, 2018 · 1 comment · Fixed by #437

Comments

@astei
Copy link
Contributor

astei commented Dec 26, 2018

If the RabbitMQ library is relocated, it will emit a spurious warning about not being able to find the client version. This is because the property string (com.rabbitmq.client.version), is rewritten but rabbitmq-amqp-client.properties is not.

This is not a server issue, only a client library issue that does not affect operations, but for completeness:

I have a PR to fix this issue, which I will open shortly.

acogoluegnes added a commit that referenced this issue Jan 2, 2019
acogoluegnes added a commit that referenced this issue Jan 2, 2019
References #436

(cherry picked from commit 4f692fe)
acogoluegnes added a commit that referenced this issue Jan 2, 2019
References #436

(cherry picked from commit 4f692fe)
acogoluegnes added a commit that referenced this issue Jan 2, 2019
References #436

(cherry picked from commit 4f692fe)
acogoluegnes added a commit that referenced this issue Jan 2, 2019
References #436

(cherry picked from commit 4f692fe)
@acogoluegnes acogoluegnes added this to the 4.9.2 milestone Jan 2, 2019
@acogoluegnes
Copy link
Contributor

@astei Thanks for this contribution. We'll release 5.5.2 with the fix in the new few days.

@acogoluegnes acogoluegnes changed the title Sprious warnings emitted by ClientVersion when the library is relocated Spurious warnings emitted by ClientVersion when the library is relocated Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants