Skip to content

Reading an unreasonably large payloadSize should throw an exception. #1217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lukebakken opened this issue Jun 9, 2022 · 0 comments · Fixed by #1218
Closed

Reading an unreasonably large payloadSize should throw an exception. #1217

lukebakken opened this issue Jun 9, 2022 · 0 comments · Fixed by #1218
Assignees
@lukebakken
Milestone
7.0.0

Comments

@lukebakken
Copy link
Collaborator

lukebakken commented Jun 9, 2022 •
edited
Loading

See the following FIXME:

rabbitmq-dotnet-client/projects/RabbitMQ.Client/client/impl/Frame.cs

Line 280 in d82e383

int payloadSize = NetworkOrderDeserializer.ReadInt32(frameHeaderSpan.Slice(2, 4)); // FIXME - throw exn on unreasonable value

The default for this value will be the default max message size for RabbitMQ, 128MiB:

https://github.com/rabbitmq/rabbitmq-server/blob/46c400afcae92bf74ce52d3ff3b53f9836297047/deps/rabbit/Makefile#L118-L119

...and it will be configurable.

Related to #1213
@lukebakken lukebakken added this to the 7.0.0 milestone Jun 9, 2022
@lukebakken lukebakken self-assigned this Jun 9, 2022
lukebakken added a commit that referenced this issue Jun 9, 2022
@lukebakken
Add ability to specify maximum message size
6da0f20 
Fixes #1217
@lukebakken lukebakken mentioned this issue Jun 9, 2022
Merged
lukebakken added a commit that referenced this issue Jun 9, 2022
@lukebakken
Add ability to specify maximum message size
878d249 
Fixes #1217
@lukebakken lukebakken mentioned this issue Jun 9, 2022
Merged
lukebakken added a commit that referenced this issue Jun 9, 2022
@lukebakken
Add ability to specify maximum message size
da56a2c 
Fixes #1217
@lukebakken lukebakken mentioned this issue Jun 15, 2022
Merged
lukebakken added a commit that referenced this issue Mar 14, 2025
@lukebakken
Skip flaky test
6f70aee 
`AlreadyClosedException` is not consistently thrown.

Related to #1572 #1356 #1217 #1218
@lukebakken lukebakken mentioned this issue Mar 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukebakken lukebakken

Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Add ability to specify maximum message size rabbitmq/rabbitmq-dotnet-client
1 participant
@lukebakken