Explicitly set reduction
for Focal loss
#1165
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Focal loss have a
reduction
parameter, but it is not set as aself.reduction
value.This does not affect loss functionality, but it can be misleading, because by default
__init__
function of_Loss
setsself.reduction
to"mean"
.For example:
This can make checks like this fail, while they should pass
This is a purely cosmetical addition that should not affect anything but can improve user experience