-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add binary segmentation example using cpu #1057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding a script example! I added a few comments to improve it and would be glad if you could work on it. Thanks a lot 🤗
Hi @qubvel! I have tried to address you comments and also, tested the code using GUP for an exemplary case of binary segmentation of buildings in the CamVid dataset. Your feedback would be appreciated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating! Looks much better, I left a few more comments. Also, let's not commit images into the repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nits, but other than that looks nice! Thanks a lot 🤗
Many thanks @qubvel. I have updated the script following your latest comments. Also, I have already tested the code on a GPU-enabled server for 100 epochs, and it works just fine. Have a good weekend! |
The one thing left - to apply |
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
@omidvarnia Thanks for contribution 🤗 |
You're welcome, @qubvel! Really appreciate your valuable review and feedback :-) |
Hi @qubvel. I have added a slightly altered version of your binary_segmentation_intro notebook, but forcing torch to use CPU without using a pl trainer, as PyTorch Lightning did not work on our cluster, likely due to a memory issue. Regards, Amir