Skip to content

Add binary segmentation example using cpu #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 18, 2025

Conversation

omidvarnia
Copy link
Contributor

Hi @qubvel. I have added a slightly altered version of your binary_segmentation_intro notebook, but forcing torch to use CPU without using a pl trainer, as PyTorch Lightning did not work on our cluster, likely due to a memory issue. Regards, Amir

Copy link
Collaborator

@qubvel qubvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a script example! I added a few comments to improve it and would be glad if you could work on it. Thanks a lot 🤗

@omidvarnia
Copy link
Contributor Author

Hi @qubvel! I have tried to address you comments and also, tested the code using GUP for an exemplary case of binary segmentation of buildings in the CamVid dataset. Your feedback would be appreciated.

Copy link
Collaborator

@qubvel qubvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating! Looks much better, I left a few more comments. Also, let's not commit images into the repo

Copy link
Collaborator

@qubvel qubvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits, but other than that looks nice! Thanks a lot 🤗

@omidvarnia
Copy link
Contributor Author

Many thanks @qubvel. I have updated the script following your latest comments. Also, I have already tested the code on a GPU-enabled server for 100 epochs, and it works just fine. Have a good weekend!

@qubvel
Copy link
Collaborator

qubvel commented Feb 15, 2025

The one thing left - to apply make fixup to make style test pass, thank you!

Copy link

codecov bot commented Feb 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@qubvel qubvel merged commit 221166f into qubvel-org:main Feb 18, 2025
16 checks passed
@qubvel
Copy link
Collaborator

qubvel commented Feb 18, 2025

@omidvarnia Thanks for contribution 🤗

@omidvarnia
Copy link
Contributor Author

You're welcome, @qubvel! Really appreciate your valuable review and feedback :-)

@qubvel qubvel mentioned this pull request Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants