Skip to content

Quickstart guide typo #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Fede1995 opened this issue Apr 15, 2025 · 3 comments · Fixed by #1126 or #1127
Closed

Quickstart guide typo #1125

Fede1995 opened this issue Apr 15, 2025 · 3 comments · Fixed by #1126 or #1127

Comments

@Fede1995
Copy link
Contributor

There is a super small typo on line 56 the Sec. 3 of the Quickstart, the image should become images in the model call, as reported at the bottom:

OLD:

for images, gt_masks in dataloader:
    predicted_mask = model(image)
    loss = loss_fn(predicted_mask, gt_masks)

    loss.backward()
    optimizer.step()

proposed NEW

for images, gt_masks in dataloader:
    predicted_mask = model(images)
    loss = loss_fn(predicted_mask, gt_masks)

    loss.backward()
    optimizer.step()
@adamjstewart
Copy link
Collaborator

Want to open a PR to fix this?

@Fede1995
Copy link
Contributor Author

If it is the preferred way, sure. I will do it

@qubvel
Copy link
Collaborator

qubvel commented Apr 15, 2025

Thanks for the issue @Fede1995! We would appreciate a PR

Fede1995 added a commit to Fede1995/segmentation_models.pytorch that referenced this issue Apr 15, 2025
@qubvel qubvel closed this as completed in d645dce Apr 15, 2025
@qubvel qubvel mentioned this issue Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants