Skip to content

Remove subprocess calls for copying archive files #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,12 @@ jobs:
--languages en
--branches 3.14

- name: Upload documentation
uses: actions/upload-artifact@v4
with:
name: www-root
path: ./www

unit:
name: Unit tests
runs-on: ${{ matrix.os }}
Expand Down
27 changes: 14 additions & 13 deletions build_docs.py
Original file line number Diff line number Diff line change
Expand Up @@ -756,22 +756,23 @@
target,
])

if not self.quick and (self.checkout / "Doc" / "dist").is_dir():
dist_dir = self.checkout / "Doc" / "dist"
if dist_dir.is_dir():

Check warning on line 760 in build_docs.py

View check run for this annotation

Codecov / codecov/patch

build_docs.py#L759-L760

Added lines #L759 - L760 were not covered by tests
# Copy archive files to /archives/
logging.debug("Copying dist files.")
chgrp(self.checkout / "Doc" / "dist", group=self.group, recursive=True)
chmod_make_readable(self.checkout / "Doc" / "dist")
run(["mkdir", "-m", "o+rx", "-p", target / "archives"])
chgrp(target / "archives", group=self.group)
run([
"cp",
"-a",
*(self.checkout / "Doc" / "dist").glob("*"),
target / "archives",
])
chgrp(dist_dir, group=self.group, recursive=True)
chmod_make_readable(dist_dir)
archives_dir = target / "archives"
archives_dir.mkdir(parents=True, exist_ok=True)
archives_dir.chmod(

Check warning on line 767 in build_docs.py

View check run for this annotation

Codecov / codecov/patch

build_docs.py#L763-L767

Added lines #L763 - L767 were not covered by tests
archives_dir.stat().st_mode | stat.S_IROTH | stat.S_IXOTH
)
chgrp(archives_dir, group=self.group)
for dist_file in dist_dir.iterdir():
shutil.copy2(dist_file, archives_dir / dist_file.name)

Check warning on line 772 in build_docs.py

View check run for this annotation

Codecov / codecov/patch

build_docs.py#L770-L772

Added lines #L770 - L772 were not covered by tests
changed.append("archives/")
for file in (target / "archives").iterdir():
changed.append("archives/" + file.name)
for file in archives_dir.iterdir():
changed.append(f"archives/{file.name}")

Check warning on line 775 in build_docs.py

View check run for this annotation

Codecov / codecov/patch

build_docs.py#L774-L775

Added lines #L774 - L775 were not covered by tests

logging.info("%s files changed", len(changed))
if changed and not self.skip_cache_invalidation:
Expand Down