Update submit PR guide #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Once your changes are reviewed and approved, you will receive an email on how | ||
| to send the final pull request to pandas. | ||
| 6. Update your pull request based on feedback | ||
| --------------------------------------------- |
There was a problem hiding this comment.
Added this section to explicitly explain how to update a PR, if that looks OK (sometimes people not familiar with this then open a new PR or so).
|
For the "4. Compile C code in pandas" section in the set-up guide, it will probably be good to have some links there how to get a C compiler on different platforms (or, mainly for windows). Our own contributing docs are however not very clear on that as well, unfortunately (http://pandas-docs.github.io/pandas-docs-travis/contributing.html#installing-a-c-compiler) |
|
Great, thanks for the changes! Gave you permissions to this repo, in case you need to make more changes. |
This was referenced Mar 1, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was reading the guides on the sprint website (nice guides!), and made a few changes along the way.